View previous topic :: View next topic |
Author |
Message |
Olyn Immortal
Joined: 23 Jul 2008 Posts: 3252 Location: Pennsylvania
|
Posted: Sun Apr 07, 2019 10:08 pm Post subject: Groups disbanding |
|
|
We've had reports for some time now about groups occasionally disbanding when certain charmed mobs leave. I took a stab at fixing a potential cause today. Let us know on here if your group still disbands at any time when it shouldn't or if anything else group-related became inadvertently worse. |
|
Back to top |
|
|
Olyn Immortal
Joined: 23 Jul 2008 Posts: 3252 Location: Pennsylvania
|
Posted: Tue Apr 09, 2019 6:13 pm Post subject: |
|
|
Are there any rangers or illusionists able to test weird group disbands and pets attacking owners? Those two classes seemed to generate the most reports prior to the fix. |
|
Back to top |
|
|
Nycticora
Joined: 09 Feb 2013 Posts: 2277
|
Posted: Wed Apr 10, 2019 8:26 am Post subject: |
|
|
there was a specific change that I remember making a long time ago that might have broken this, I'll try to remember what it was. There was a group + reaper bug and I drastically changed the way groups work and I remember both dav and I were surprised when it worked
I think it was when we added the necro skeleton and let pets group, there might be something wrong with groups that have a leader with a pet who isn't in the group, or maybe issues where a pet is erroneously marked as the group leader when someone leaves or dies
I remember being confused at the difference between leader and master and what happened when one was enabled but not the other |
|
Back to top |
|
|
Nycticora
Joined: 09 Feb 2013 Posts: 2277
|
Posted: Wed Apr 10, 2019 8:33 am Post subject: |
|
|
f326a7e782b55406670019df23a338a96f6572f9 was the original commit that added this logic, might be able to compare that CL to current state to see what's up
this system has seen lots of work, it looks way improved now compared to how it was in 2017
it looks like the most likely way to break a group should be when you add a mob following one of your groupmembers to the group, and then that mob either dies or leaves due to the parent leaving (logging out?). Or maybe a duplicate disappearing.
Issue 4 is probably less relevant to current state than issue 215, issue 4 is too old. |
|
Back to top |
|
|
|